Skip to content

chore: update fullsend shim workflow#1767

Open
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard
Open

chore: update fullsend shim workflow#1767
fullsend-ai-fullsend[bot] wants to merge 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

Update the shim workflow to match the current template
in the .fullsend config repo.
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 7, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:48 AM UTC · Completed 8:53 AM UTC
Commit: 7c8ccca · View workflow run →

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unit-tests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fullsend-ai-review

Copy link
Copy Markdown

Review — comment

Summary

This PR removes the Apache 2.0 license header (14 lines, including the SPDX identifier) from .github/workflows/fullsend.yaml to sync the shim workflow with the upstream template in the .fullsend config repo.

The change is comment-only — no functional impact to the workflow definition. However, it conflicts with the repository's own license-header enforcement.

Findings

⚠ License header removal breaks CI lint check — medium

File: .github/workflows/fullsend.yaml

The repository enforces license headers on all files via addlicense -check (invoked by make lint, which is part of make ci). All 8 other workflow files in .github/workflows/ have the standard header:

# Copyright The Conforma Contributors
#
# Licensed under the Apache License, Version 2.0 (the "License");
# ...
# SPDX-License-Identifier: Apache-2.0

Removing the header from fullsend.yaml causes the pre-merge-ci workflow to fail — the all-tests-and-checks job's "Run checks" step (make ci) is currently failing on this PR.

Remediation options:

  1. Keep the license header — restore the removed block (and optionally add the missing Copyright The Conforma Contributors line to match the exact format used by other workflow files).
  2. Exclude the file from addlicense — add -ignore '.github/workflows/fullsend.yaml' to the LICENSE_IGNORE variable in the Makefile if the intent is for this file to remain header-free and template-managed. This would need to be a deliberate project decision.

Dimensions reviewed

Dimension Result
Correctness ✅ No issues — comment-only change, no logic affected
Security ✅ No issues — no changes to permissions, triggers, or secrets handling
Intent & coherence ⚠ Intent is clear (template sync), but conflicts with repo conventions
Style/conventions ⚠ License header inconsistency with all other workflow files; CI lint failure
Documentation ✅ No documentation impact
Cross-repo contracts ✅ No API or interface changes

Labels: PR modifies a GitHub Actions workflow file

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment github_actions Pull requests that update GitHub Actions code labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code requires-manual-review Review requires human judgment size: XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants