Shim testing framework - #306
Merged
Merged
Conversation
jprendes
force-pushed
the
shim-tests-framework
branch
13 times, most recently
from
September 11, 2023 18:32
6354bd0 to
87a1985
Compare
jprendes
marked this pull request as ready for review
September 11, 2023 18:37
jprendes
force-pushed
the
shim-tests-framework
branch
from
September 11, 2023 22:09
87a1985 to
87fc1a0
Compare
Collaborator
Author
|
It turns out that the wasmer shim rootfs preopen setup is a bit more involved than initially thought. |
jprendes
force-pushed
the
shim-tests-framework
branch
from
September 11, 2023 22:33
87fc1a0 to
403b5db
Compare
Mossaka
previously approved these changes
Sep 12, 2023
Mossaka
left a comment
Mossaka
left a comment
Member
There was a problem hiding this comment.
LGTM! I love how this testing framework simplies a lot the repeated code in all three shims. Thank you for this amazing work!
I had a few comments / questions. Not a blocker.
Member
|
Need a rebase |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
jprendes
force-pushed
the
shim-tests-framework
branch
from
September 12, 2023 20:55
6490f49 to
089bbe5
Compare
Collaborator
Author
|
Rebased |
This was referenced Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to set the bases to build what's been proposed in #111 .
It creates a new crate that wasm shim implementors can use to test their shims.