feat(ci): add typecheck and lint to PR workflow and fix existing errors - #706
Open
Saloni3494 wants to merge 1 commit into
Open
feat(ci): add typecheck and lint to PR workflow and fix existing errors#706Saloni3494 wants to merge 1 commit into
Saloni3494 wants to merge 1 commit into
Conversation
Fixes: containers#607 Signed-off-by: Saloni Tanmor <saloni.tanmor1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
yarn typecheckandyarn lintsteps to the.github/workflows/setup_and_build.ymlworkflow. Because this workflow is reused by both the test and deploy jobs, this enforces code quality checks on every PR and main branch push.eslint-plugin-prettieras a dev dependency and upgradedprettierto resolve themodule not foundissue that was causingyarn lintto fail immediately on the main branch (addresses yarn lint fails immediately: ESLint couldn't find the plugin eslint-plugin-prettier #542).Why this change is needed
Currently, there is no typecheck or linting enforced in the CI pipeline for Pull Requests. This means typos, unused variables, and type mismatch errors can easily slip into the
mainbranch unnoticed. By moving these checks directly into the GitHub Actions workflow, we establish a strict quality gate that prevents bad code from being deployed.Because adding this check would have instantly broken the CI due to preexisting linting errors and missing dependencies on
main, I also resolved the missingeslint-plugin-prettiermodule and patched the remaining ESLint errors throughout the codebase to ensure a green build.Testing
yarn typechecksucceeds locally.yarn lintsucceeds locally with 0 errors..github/workflows/setup_and_build.ymlis valid.Fixes: #607
Fixes: #542
Checklist
git commit -s). The author email must match the sign-off email address.Fixes: #00000in the commit message.