docs: fix typos in CONTRIBUTING.md#1796
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request corrects several typos and grammatical errors in the CONTRIBUTING.md file, including fixing possessive pronouns, word spacing, and spelling mistakes. A review comment suggests further refining the text by removing the hyphen from 'false-positive' when used as a noun, which aligns with the PR's objective of improving documentation clarity.
| Toolbx has a CI (Continuous Integration) setup for running tests. Their goal is to check if your | ||
| changes don't affect adversely Toolbx's functionality. Sometimes these tests | ||
| mail fail with a false-positive. If you are not sure about the outcome of the | ||
| may fail with a false-positive. If you are not sure about the outcome of the |
There was a problem hiding this comment.
The term "false positive" is typically used as two separate words when functioning as a noun. Hyphenation is generally reserved for its use as a compound adjective (e.g., "a false-positive result"). Since this pull request specifically targets typos and wording improvements, it would be better to use the standard noun form here.
| may fail with a false-positive. If you are not sure about the outcome of the | |
| may fail with a false positive. If you are not sure about the outcome of the |
1 participant
A few lines in
CONTRIBUTING.mdhave obvious wording slips, so the contributor guide reads kinda rough in a couple spots. Tiny paper cutOpen
CONTRIBUTING.md, read the lines withsome of it's functionality,as it's buildsystem,has it's documentation,take the us some time, andmail fail. The typos show up right awayThis PR just cleans up those phrases