Skip to content

Fix compatibility with nette/forms 3.3 - #126

Open
slischka wants to merge 4 commits into
contributte:masterfrom
fapi-cz:master
Open

Fix compatibility with nette/forms 3.3#126
slischka wants to merge 4 commits into
contributte:masterfrom
fapi-cz:master

Conversation

@slischka

Copy link
Copy Markdown

Summary

  • keep Multiplier::getControls() compatible with the Iterator return type while accepting the iterable returned by nette/forms 3.3
  • add a regression test for the public return type
  • update testing-helpers and keep the test-only nette/application dependency below 3.3 because testing-helpers 4.1.1 has an incompatible LatteFactory::create() signature

Verification

  • test suite passes with nette/forms 3.3.0
  • test suite and PHPStan pass with the lowest supported dependencies (nette/forms 3.2.4)
  • CodeSniffer passes

slischka and others added 4 commits July 26, 2023 14:02
# Conflicts:
#	composer.json
…rms-3-3

Updated upstream and added Nette Forms 3.3 compatibility
@slischka
slischka marked this pull request as ready for review July 24, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant