change from 3 digits to 6 digits in print out - #56
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@bqpd I need help making this nice and better before merging. |
| @@ -0,0 +1,51 @@ | |||
| """Standard Python setup script for GPkit Models""" | |||
| LONG_DESCRIPTION = """ | ||
| GPkit Models is a library of geometric programming and signomial programming | ||
| models that can be manipulated and solved using | ||
| `GPfit <https://github.com/hoburg/gpfit/>`_. |
| author="MIT Department of Aeronautics and Astronautics", | ||
| author_email="gpfit@mit.edu", | ||
| url="https://www.gifhub.com/hoburg/gpfit", | ||
| install_requires=["numpy", "scipy", "pint"], |
There was a problem hiding this comment.
So I saw scipy and left it in. Deleted pint.
| description="program to convert data into GP compatible functions that " | ||
| "can be used with GPkit.", | ||
| author="MIT Department of Aeronautics and Astronautics", | ||
| author_email="gpfit@mit.edu", |
There was a problem hiding this comment.
do we have this email address?
|
I'm going to try to rebase this to fix the merge conflicts. |
whoburg
changed the title
whoburg
changed the title
|
@mjburton11, gpfit alreadsy has a |
|
just force pushed, please delete and re-fetch any local copies of the |
|
test this please |
1 similar comment
|
test this please |
|
I realized I needed to update the gpfit scripts for mosek 8. I think I just got it. |
|
test this please |
|
pylint is failing with 0 errors, 0 warnings? |
|
test this please |
|
hmm, it's not triggering the build for some reason... |
|
just checked and acdl-jenkins does have admin access |
|
can you try pushing something to this PR |
|
very strange... let me reboot jenkins |
|
test this please |
|
not sure why this isn't starting, but Jenkins might think this PR is closed for some reason... That's all I can see from the log. |
|
hm, should I try cherry-picking these commits to a new PR? |
|
Worth a try |
|
Maybe closing and reopening the PR? |
|
Can one of the admins verify this patch? |
|
add to whitelist |
|
That seems to have fixed it |
|
Test this please |
|
easy there jenkins |
|
@galbramc, why the disagreement in pylint status between macys and Reynolds? |
|
That's what that did. There was a new feature in the plugin to apparently show every single build in the matrix. That might be too much. Want me to turn it off? |
|
I'm going to turn that off again. Looks like information overload. Looks like the counts are off for Reynolds. Could you create an "CI test" PR so I can reset the counts. |
|
Testing jenkins privelages |
|
Test this please |
|
Alright, looks like you are good to go. |
|
yes -- thanks! |
whoburg
left a comment
whoburg
left a comment
There was a problem hiding this comment.
@mjburton11 or @bqpd, I approve. Is this ready to merge?
|
@mjburton11, it's all you. |
|
@mjburton11, please "squash and merge" as opposed to creating a merge commit (if ready to merge) |
|
I am ready to merge. How do I "squash and merge"? |
|
Click the arrow next to |
|
@mjburton11, the last step is to delete the branch. |
|
right... sorry |
5 participants
Increase the number of digits in the gpfit print out from 3 to 6. Increases fit accuracy.