[fix] Fix dev container build#30
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the dev container build by reorganizing the Docker setup and moving installation scripts to a more organized structure.
Changes:
- Consolidated Docker configuration by removing the old generic
Dockerfileand separating concerns intoDockerfile.devfor development andDockerfile.deployfor deployment - Moved
install.shtoscripts/install_extra.shfor better organization and updated all references - Created
scripts/deployed_entrypoint.shto handle container startup for deployment scenarios - Added Docker Buildx setup to CI/CD workflows and updated documentation with warnings about the buildx requirement
- Improved Dockerfile practices by adding a non-root
cevuser and updating development tooling from clang-format to clangd
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/install_extra.sh | New script containing system package installation logic moved from root install.sh |
| scripts/deployed_entrypoint.sh | New entrypoint script for deployment container that sources ROS environment and launches specified autonomy configurations |
| install.sh | Removed - functionality moved to scripts/install_extra.sh |
| README.md | Updated installation and deployment instructions to reflect new script locations and added Docker buildx warnings |
| Dockerfile.dev | Development container with user setup, clangd installation, and dependency management |
| Dockerfile.deploy | Deployment container optimized with staged builds and proper entrypoint configuration |
| Dockerfile | Removed - replaced by separate dev and deploy Dockerfiles |
| .github/workflows/docker-image.yml | Split CI workflow into separate jobs for building dev and deploy containers with buildx setup |
| .devcontainer.json | Updated to use cev user and switched from clang-format extension to clangd |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.