Skip to content

Fixed mean_cache data extraction for dKG - #2452

Open
yyexela wants to merge 6 commits into
cornellius-gp:mainfrom
yyexela:master
Open

Fixed mean_cache data extraction for dKG#2452
yyexela wants to merge 6 commits into
cornellius-gp:mainfrom
yyexela:master

Conversation

@yyexela

@yyexela yyexela commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Issue: dKG in BoTorch no longer works since I last ran it a few months ago. It appears to be from the mean_cache going from size [num_fantasies, 1, 1, num_data] to [num_fantasies, num_fantasies, num_fantasies, num_data]. What this change does is extract the relevant data of mean_cache while keeping the expected shape for the rest of the code (ie. [num_fantasies, 1, num_data]).

Not sure about a unit test for this since it depends on having BoTorch's qKnowledgeGradient class, among other dependencies.

See meta-pytorch/botorch#2137

@yyexela

yyexela commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Any idea why the unit test is failing when there is no code change?

@yyexela

yyexela commented Dec 4, 2023

Copy link
Copy Markdown
Contributor Author

Noticed main fails the same test so I'm assuming my code works and it's another problem.

EDIT: Unit tests aren't passing but neither are the ones in main, so I'll assume this change is what's needed for now.

yyexela referenced this pull request in yyexela/botorch Jan 19, 2024
@CedricTravelletti

Copy link
Copy Markdown

Any news on this PR? I confirm that there is interest in gradient-enabled GPs/BO for several application cases.

@nrummel

nrummel commented Jun 12, 2026

Copy link
Copy Markdown

I am also hoping to have this change in the main branch, as I would like to use derivative information for Bayesian Optimization through BoTorch.

@yyexela

yyexela commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@gpleiss any way we can get this through? It's a simple fix that would allow people to run this botorch notebook, there's clearly an interest in the community to do work on dGPs (meta-pytorch/botorch#2137).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants