Refresh Spring Boot and Couchbase dependencies#148
Conversation
|
Owner ping for this maintenance PR: @teetangh @jdmuntacb Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request. |
There was a problem hiding this comment.
Code Review
This pull request updates several dependency and plugin versions in the pom.xml and modifies the Spring Boot version reference in .env.example. However, the review identifies that most of the proposed versions—including those for Spring Boot, the Couchbase SDK, and various Maven plugins—do not exist in Maven Central and will cause build failures. Additionally, the documentation update refers to a non-existent Spring Boot 4.0 release and should be corrected to a valid version.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>4.0.1</version> | ||
| <version>4.0.3</version> |
There was a problem hiding this comment.
The version 4.0.3 for spring-boot-starter-parent does not exist in Maven Central. The current stable major version is 3.x (e.g., 3.4.3). Using a non-existent version will prevent the project from building as the parent POM cannot be resolved.
| <version>4.0.3</version> | |
| <version>3.4.3</version> |
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> | ||
| <couchbase.version>3.10.0</couchbase.version> | ||
| <couchbase.version>3.11.1</couchbase.version> |
There was a problem hiding this comment.
The version 3.11.1 for couchbase.version (Couchbase Java SDK) is not a valid release. The latest stable version in the 3.x series is 3.7.7. Additionally, other versions in this block like lombok.version 1.18.42 and springdoc.version 3.0.1 also appear to be non-existent.
| <couchbase.version>3.11.1</couchbase.version> | |
| <couchbase.version>3.7.7</couchbase.version> |
| <springdoc.version>3.0.1</springdoc.version> | ||
| <junit.version>4.13.2</junit.version> | ||
| <maven-surefire.version>3.5.4</maven-surefire.version> | ||
| <maven-surefire.version>3.5.5</maven-surefire.version> |
There was a problem hiding this comment.
The version 3.5.5 for maven-surefire-plugin is not available. The latest stable release is 3.5.2. Using non-existent plugin versions will cause build failures during the test phase.
| <maven-surefire.version>3.5.5</maven-surefire.version> | |
| <maven-surefire.version>3.5.2</maven-surefire.version> |
| <groupId>io.github.cdimascio</groupId> | ||
| <artifactId>dotenv-java</artifactId> | ||
| <version>3.0.2</version> | ||
| <version>3.2.0</version> |
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.14.0</version> | ||
| <version>3.15.0</version> |
| # | ||
| # These environment variables are used for database connection | ||
| # and correspond to the Spring Boot 3.5+ Couchbase properties: | ||
| # and correspond to the Spring Boot 4.0+ Couchbase properties: |
There was a problem hiding this comment.
The reference to 'Spring Boot 4.0+' is incorrect as Spring Boot 4 has not been released. The properties listed (e.g., spring.couchbase.connection-string) were introduced in Spring Boot 3.0. This should be updated to 'Spring Boot 3.0+' to avoid confusion.
# and correspond to the Spring Boot 3.0+ Couchbase properties:
Summary
4.0.1to4.0.33.10.0to3.11.1, dotenv-java to3.2.0, maven-compiler-plugin to3.15.0, and surefire/failsafe to3.5.5.env.examplecomment drift so it references the current Spring Boot 4.0+ Couchbase property surfaceVerification
JAVA_HOME=/usr/lib/jvm/java-21-openjdk-arm64 ./mvnw clean test -BJAVA_HOME=/usr/lib/jvm/java-17-openjdk-arm64 ./mvnw clean test -BJAVA_HOME=/usr/lib/jvm/java-17-openjdk-arm64 ./mvnw spring-boot:run -Dspring-boot.run.arguments=--server.port=18080curl -I http://127.0.0.1:18080/curl -s http://127.0.0.1:18080/swagger-ui/index.htmlcurl -s http://127.0.0.1:18080/v3/api-docscurl -s http://127.0.0.1:18080/api/v1/airport/airport_1255curl -s "http://127.0.0.1:18080/api/v1/airline/list?country=France&limit=2&offset=0"Evidence
mainpassed locally on JDK 21:18tests,0failures,0errors18tests,0failures,0errorstravel-sample/redirected to Swagger UI,/v3/api-docsreportedQuickstart in Couchbase with Spring Bootwith8paths, and the airport / airline endpoints returned expected live dataspring-boot:runattempt on the default port hit a local8080port conflict, so the walkthrough was re-run successfully on18080tutorial-maintenance/runs/java-springboot-quickstart/2026-05-05T0145Z-subagent/verification.mdtutorial-maintenance/runs/java-springboot-quickstart/2026-05-05T0145Z-subagent/commands.txttutorial-maintenance/runs/java-springboot-quickstart/2026-05-05T0145Z-subagent/baseline-test.logtutorial-maintenance/runs/java-springboot-quickstart/2026-05-05T0145Z-subagent/updated-test-jdk17.logtutorial-maintenance/runs/java-springboot-quickstart/2026-05-05T0145Z-subagent/app-run-18080.logtutorial-maintenance/runs/java-springboot-quickstart/2026-05-05T0145Z-subagent/walkthrough-requests-3.txtNotes