Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the API documentation descriptions for the hotel autocomplete and filter endpoints to reflect the correct file paths, repository links, and method names. The feedback suggests using the full file path app/routers/hotel.py instead of routers/hotel.py to maintain consistency with the actual project structure and the provided GitHub links.
fd12f30 to
820f86c
Compare
Contributor
Author
|
Owner ping for this maintenance PR: @nithishr Requesting review from the manifest-listed owner(s) where GitHub does not already show a pending review request. |
nithishr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
origin/mainon a freshdeps/update-2026-04-29branchpip list --outdated --format=jsonreturned[]) and the app/test flow is healthy on mainVerification
uv venv --seed --python /usr/bin/python3.14 .venvpython -m pip install -r requirements.txtpython -m pip list --outdated --format=json→[]python -m pytest→47 passeduvicorn app.main:app --host 127.0.0.1 --port 8000curl -i http://127.0.0.1:8000/→307redirect to/docscurl -s "http://127.0.0.1:8000/api/v1/airport/list?country=France&limit=2"curl -s "http://127.0.0.1:8000/api/v1/hotel/autocomplete?name=Seal"curl -s -X POST "http://127.0.0.1:8000/api/v1/hotel/filter?limit=2" -H "Content-Type: application/json" -d {country:United States}python -m pytestre-run →47 passedEvidence
/api/v1/hotel/autocomplete/api/v1/hotel/filtercouchbase-examples/python-quickstart/blob/main/src/api/hotel.py, which is the wrong repo/path for this project./openapi.jsonpoints both hotel endpoints atcouchbase-examples/python-quickstart-fastapi/blob/main/app/routers/hotel.pyand shows the actual handler nameshotel_autocomplete/hotel_filter.pytest output
API walkthrough excerpt
tutorial-maintenance/runs/python-quickstart-fastapi/2026-04-29T20-23-30Z/verification.mdtutorial-maintenance/runs/python-quickstart-fastapi/2026-04-29T20-23-30Z/walkthrough.logtutorial-maintenance/runs/python-quickstart-fastapi/2026-04-29T20-23-30Z/walkthrough-after-fix.logNotes
origin/main; existing PR Update deps and retest quickstart flow #227 was left untouched.