Fixed a compile error in AtomicRefCounted tests#306
Merged
Conversation
pasin
reviewed
Jun 18, 2026
pasin
left a comment
Collaborator
There was a problem hiding this comment.
There is also a failure on Android (32 bits) in PR validation done by Jenkins, here.
[2026-06-17T19:36:53.163Z] /home/couchbase/jenkins/workspace/line_couchbase-lite-core_PR-2503/couchbase-lite-core/vendor/fleece/Fleece/Support/RefCounted.cc:139:36: error: constexpr variable 'kBusyMask' must be initialized by a constant expression
[2026-06-17T19:36:53.163Z] 139 | static constexpr uintptr_t kBusyMask = uintptr_t(1) << 63;
[2026-06-17T19:36:53.163Z] | ^ ~~~~~~~~~~~~~~~~~~
[2026-06-17T19:36:53.163Z] /home/couchbase/jenkins/workspace/line_couchbase-lite-core_PR-2503/couchbase-lite-core/vendor/fleece/Fleece/Support/RefCounted.cc:139:61: note: shift count 63 >= width of type 'uintptr_t' (aka 'unsigned int') (32 bits)
[2026-06-17T19:36:53.163Z] 139 | static constexpr uintptr_t kBusyMask = uintptr_t(1) << 63;
borrrden
approved these changes
Jun 18, 2026
pasin
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In LiteCore PR couchbase/couchbase-lite-core#2503 the Ubuntu build failed with a GCC error building Fleece tests, in
This is a regression introduced by #272 / #303 but it wasn't caught in Fleece's CI, apparently because Fleece's CI builds with GCC on Ubuntu, while LiteCore builds with Clang; and probably a different Clang than Fleece uses on macOS since it didn't get this error either.