fix typo; fix integer overflow for 32bit systems - #34
Open
MrEcco wants to merge 1 commit into
Open
Conversation
Author
|
Look here: Line 43 in 1ba5406 int(math.MaxUint32) and for 32-bit size pointers it collapses.
|
Author
|
Tried to build my ARG GOTEMPLATE_VERSION=3.12.0
RUN cd /tmp && \
apk add --no-cache \
git \
go && \
git config --global advice.detachedHead false && \
git clone --depth 1 --branch v${GOTEMPLATE_VERSION} https://github.com/coveooss/gotemplate && \
cd gotemplate && \
go build -ldflags "-s -w" . && \
strip -g -S -d --strip-debug ./gotemplate# command
docker buildx build --progress plain --platform linux/arm/v7 .
docker buildx build --progress plain --platform linux/arm/v6 .Got this error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got this error while building your
gotemplateproject forlinux/arm/v6andlinux/arm/v7. This looks like an obvious miss of support of 32bit -based systems. I bet you skip such systems because of various places where it might not work, but if this PR doesn't hurt then it might be a small stop toward it.I'm not familiar with where you use this library, so cannot guarantee it doesn't break something :)