Fix: syswrite/sysread negative length should die, not warn - #421
Draft
toddr-bot wants to merge 1 commit into
Draft
Fix: syswrite/sysread negative length should die, not warn#421toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
Real Perl's syswrite/sysread with a negative length argument is fatal (die), not a warning. The mock was using CORE::warn which let execution continue — diverging from real behavior and masking bugs in test suites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syswrite/sysreadwith negative length is fatal (die), but the mock only warned — allowing execution to continue and diverging from real behaviorCORE::warntodieinFileHandle.pmWRITE and READ methodst/sysreadwrite_edge_cases.tandt/portability_errno.tCloses #420
Test plan
t/sysreadwrite_edge_cases.t— negative length tests now expectdieviaevalt/portability_errno.t— same update for both syswrite and sysread subtestst/fh-ref-leak.tfailure, unrelated)syswrite($fh, "x", -1)dies with "Negative length"Quality Report
Changes: 3 files changed, 18 insertions(+), 44 deletions(-)
Code scan: clean
Tests: failed (4 Failed, 94 test)
Branch hygiene: clean
Generated by Kōan