test: make fh-ref-leak.t green with TODO guards for unfixed OFC - #422
Draft
toddr-bot wants to merge 1 commit into
Draft
test: make fh-ref-leak.t green with TODO guards for unfixed OFC#422toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
Overload::FileCheck retains filehandle refs in its internal $_last_call_for cache (GH cpan-authors#179, OFC PR cpan-authors#25). The test correctly validates the expected behavior but was failing on main because the upstream fix hasn't shipped yet. Add a runtime probe that detects whether the fix is present and wraps the three affected assertions in Test2 todo guards when it is not. Tests auto-promote to hard assertions once OFC ships the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
t/fh-ref-leak.tpass on main by wrapping three assertions in conditional TODO guards.Why
The test validates GH #179 (filehandle reference leak via Overload::FileCheck's
$_last_call_forcache). The expected behavior is correct, but the upstream fix (OFC PR #25) hasn't shipped. Without TODO guards, the test suite reports 3 failures on every run — noise that hides real regressions.How
A runtime probe at load time checks whether OFC still retains refs. When it does, Test2 todo guard objects wrap the three affected assertions. Once OFC ships the fix, the probe detects it and the assertions auto-promote to hard pass/fail — no code change needed.
Testing
prove -l t/fh-ref-leak.t— 4/4 pass (3 as TODO)Quality Report
Changes: 1 file changed, 33 insertions(+), 3 deletions(-)
Code scan: 1 issue(s) found
t/fh-ref-leak.t:27— TODO commentTests: passed (OK)
Branch hygiene: clean
Generated by Kōan