feat(renovate): automerge lock file maintenance PRs - #125
Merged
Conversation
lockFileMaintenance joins the automerge allowlist. It was left out when 3f827de replaced the global automerge=true with an explicit update-type allowlist, which made the weekly batch (~10 repos, one PR per lockfile) go green in about a minute and then sit until merged by hand. That hand-merge reviewed nothing: a regenerated lockfile is not meaningfully reviewable, and the PRs are structurally release-inert because lockfiles sit in the CI detect job's path-exclusion list, so a lockfile-only push cannot publish or tag. rollback, replacement and bump still fail closed. Verified against Renovate 44.7.3's own code rather than by inspection: applyPackageRules from dist/util/package-rules, fed a synthetic config per update type, flips exactly one cell (lockFileMaintenance false -> true) with patch/minor still true and major/rollback/bump/replacement still false. flatten.js confirms packageRules do apply to the lock-file-maintenance config, and that dep-level matchers (the git-cliff and tool-registry automerge=false rules) cannot match it. renovate-config-validator --strict passes but does not gate this change: it rejects a typo'd matcher key while silently accepting a bogus enum value inside matchUpdateTypes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lockFileMaintenancejoins the automerge allowlist indefault.json.Why
It was left out when
3f827dereplaced the globalautomerge: truewith anexplicit update-type allowlist. The effect fleet-wide: the weekly lock file
maintenance batch (~10 repos, one PR per lockfile) went green in about a minute
and then sat until merged by hand. The two batches after that commit were
merged in manual same-second clusters, 14 minutes and 3 days after creation
respectively, and this week's 10 were still open.
That hand-merge reviewed nothing. A regenerated lockfile is not meaningfully
reviewable, and the PRs are structurally release-inert: lockfiles sit in the CI
detectjob's path-exclusion list, so a lockfile-only push hasroot_changed=falseand cannot publish or tag.rollback,replacementandbumpstill fail closed to manual review.Verification
renovate-config-validator --strictpasses, but it does not gate thischange: it rejects a typo'd matcher key (
matchUpdateTypesTYPO) while silentlyaccepting a bogus enum value inside
matchUpdateTypes(
lockFileMaintenanceTYPOvalidates clean). So the change was verified againstthe running Renovate 44.7.3's own code instead —
applyPackageRulesfromdist/util/package-rules, fed a synthetic config per update type:falsetruetruetruetruetruefalsefalsefalsefalsefalsefalsefalsefalseExactly one cell flips. Two supporting facts from the same source:
workers/repository/updates/flatten.jssetsupdateTypeon thelock-file-maintenance config and calls
applyPackageRuleson it twice, so arule whose only matcher is
matchUpdateTypesdoes apply to it.automerge: falsesupply-chain rules (git-cliff asset swap,tool-registry retag) both carry
matchDepNames, which can never match aconfig that has no dep, so they cannot collide with this rule.
Effect on the 10 already-open PRs
They pick the new policy up on the next Renovate run even though the Monday
schedule window has closed: with a branch and a PR both already present and
updateNotScheduledat its defaulttrue,update/branch/index.jslogs "Branch + PR exists but is not scheduled -- willupdate if necessary" and falls through to the automerge check rather than
returning
not-scheduled.Documented in
cplieger/.kirosteering/ci-renovate.md.