fix(renovate): group the toolbelt module with its Dockerfile ARG pin - #127
Merged
Conversation
The toolbelt consumers pin github.com/cplieger/toolbelt/v2 twice: go.mod for the runtime engine, and ARG TOOLBELT_TOOLCATALOG_VERSION for the build-time toolcatalog verifier. web-terminal-kiro's builder asserts the two are equal, so a half-bump fail-closes every image build. The pins reached Renovate through different managers (gomod vs the generic Dockerfile-ARG custom.regex), so one release produced two half-PRs: vibekit #827 (ARG only) plus #828 (go.mod only), and web-terminal-kiro#666 (go.mod only) red on the pin gate. Group them by depName the same way the kiro-cli and golang-toolchain pin pairs already are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toolbelt consumers pin
github.com/cplieger/toolbelt/v2twice on purpose:go.modrequires the runtime engine that re-verifiesrequired-tools.txtbefore every catalog swap.ARG TOOLBELT_TOOLCATALOG_VERSIONselects the build-timetoolcatalog verifybinary.web-terminal-kiro's builder asserts the two are equal (
toolbelt-pin-gate), so a half-bump does not drift silently — it fail-closesci / docker,ci / docker-arm64, and the Trivy image scan until the second pin catches up.Those two pins reach Renovate through different managers:
gomod(swept into theGo dependenciesgroup branch) and the generic Dockerfile-ARGcustom.regexmanager (its own per-dep branch). Nothing grouped them, so the v2.4.2 release produced half-PRs that could not be green and complete on their own:This adds a
toolbeltgroup keyed onmatchDepNames, the same cross-manager coupling model thekiro-cliandgolang toolchaingroups already use, and for the same reason: a pin pair that a build gate compares must never be splittable into two branches.Notes on the shape:
gomodGo dependenciesrule so itsgroupNamewins the rule merge for toolbelt deps.separateMajorMinorleft at the default — both pins are the same dep at the same version, so they always carry the same update type, and a toolbelt major stays behind the manual major gate./**entry keeps the group intact across a future Go semantic-import major (toolbelt/v3).Validation:
renovate-config-validatorexits 0, and a minimatch check confirms the patterns matchtoolbelt,toolbelt/v2, andtoolbelt/v3without over-matchingtoolbelt-extraor any othercplieger/*module.