Skip to content

Fix #14710 False positive: func arg names different when using VLAs #8510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrchr-github merged 2 commits into from
Apr 29, 2026
+6 −2
Merged

Fix #14710 False positive: func arg names different when using VLAs #8510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3704b6a
Update checkother.cpp
chrchr-github Apr 29, 2026
5c5cf42
Update testother.cpp
chrchr-github Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/checkother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4044,8 +4044,8 @@ void CheckOther::checkFuncArgNamesDifferent()
decl = decl->nextArgument();
break;
}
// skip over template
if (decl->link() && decl->str() == "<")
// skip over templates and arrays
if (decl->link() && decl->str() != "(")
decl = decl->link();
else if (decl->varId())
declarations[j] = decl;
Expand Down
4 changes: 4 additions & 0 deletions test/testother.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12930,6 +12930,10 @@ class TestOther : public TestFixture {
"[test.cpp:9:20] -> [test.cpp:14:22]: (warning) Function 'func2' argument order different: declaration 'a, b, c' definition 'c, b, a' [funcArgOrderDifferent]\n"
"[test.cpp:10:20] -> [test.cpp:15:22]: (warning) Function 'func3' argument order different: declaration 'a, b, c' definition 'c, b, a' [funcArgOrderDifferent]\n"
"[test.cpp:11:16] -> [test.cpp:16:22]: (warning) Function 'func4' argument order different: declaration ', b, c' definition 'c, b, a' [funcArgOrderDifferent]\n", errout_str());

check("void f(int N, const int a[N], const int b[N]);\n" // #14710
"void f(int N, const int a[N], const int b[N]) {}\n");
ASSERT_EQUALS("", errout_str());
}

// #7846 - Syntax error when using C++11 braced-initializer in default argument
Expand Down
Loading