Skip to content

Fix `AttributeError: 'CrateCompilerSA20' object#278

Merged
bgunebakan merged 1 commit into
mainfrom
fix/visit-on-conflict-do-update
Jun 22, 2026
Merged

Fix `AttributeError: 'CrateCompilerSA20' object#278
bgunebakan merged 1 commit into
mainfrom
fix/visit-on-conflict-do-update

Conversation

@bgunebakan

Copy link
Copy Markdown
Contributor

Summary of the changes / Why this is an improvement

Moves visit_on_conflict_do_update and _on_conflict_target from CrateTypeCompiler to CrateCompiler. This is a bug fix for a misplaced method introduced in GH-264.

Checklist

  • Link to issue this PR refers to (if applicable): Fixes #???
  • Added tests

@bgunebakan bgunebakan self-assigned this Jun 19, 2026
@bgunebakan bgunebakan added the bug Something isn't working label Jun 19, 2026
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: faac5712-f122-42d9-8176-5a64a03de740

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/visit-on-conflict-do-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bgunebakan bgunebakan force-pushed the fix/visit-on-conflict-do-update branch from 65a5a47 to 8d7c138 Compare June 19, 2026 11:18

@amotl amotl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding test cases.

@amotl

amotl commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@kneth: Can you also acknowledge so we can bring this in? 🙏

@bgunebakan bgunebakan merged commit 48cae8d into main Jun 22, 2026
27 checks passed
@bgunebakan bgunebakan deleted the fix/visit-on-conflict-do-update branch June 22, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants