-
-
Notifications
You must be signed in to change notification settings - Fork 404
Feat/pgo v3 #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
henderkes
wants to merge
86
commits into
v3
Choose a base branch
from
feat/pgo-v3
base: v3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/pgo v3 #1138
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
4f76942
toolchain fixes forward port from v2-pgo
henderkes 6e32672
better deduplicate_flags
henderkes efdd2a7
update libraries to honour user flags
henderkes 743934d
use resolved dependency tree instead of asking for with_suggests ever…
henderkes 7e6e9d8
add pgo capabilities v3 style
henderkes bfaa7eb
Merge remote-tracking branch 'origin/v3' into feat/pgo-v3
henderkes a585359
reset registry
henderkes 4172508
use {pkg_root_path} for packages, otherwise containers get confused w…
henderkes 270e2d6
cant reset it because of the same reason x(
henderkes c1c34d8
trust filesystem, not downloads
henderkes 8453f69
fix BUILD_CC=cc workaround root cause (minijit trips zig default unde…
henderkes 57ef042
fix phpunit failure
henderkes defd50f
wrong exception type
henderkes 814014e
array
henderkes 2415b7d
we don't need this anymore
henderkes 4754faf
also build curl exe on windows
henderkes 445c0b3
don't add fno-sanitize=undefined for library builds
henderkes 9addbe2
oops
henderkes b880ef7
allow * stage to subscribe to everything
henderkes db794bf
strange shit
henderkes 09de4c9
drop ldflags fron watcher-c
henderkes 6fda358
--build-frankenphp didn't actually build frankenphp
henderkes a88e426
clean cgo cache before rebuilding frankenphp (reports wrong version f…
henderkes 70e717a
fix version reevaluating regression from v2
henderkes 1707d21
don't extract local sources
henderkes 4b19f4e
forward port #1138
henderkes 07aae79
forward port #1142
henderkes 19d1379
better cross compile compatibility
henderkes 697040b
Trim base namespace for registry
crazywhalecc fdc75cb
Allow vendor mode loading default registry file
crazywhalecc ce70c0d
Register artifacts dynamically if not already initialized
crazywhalecc f27ec77
Refactor clang runtime bits support for zig integration
crazywhalecc 32da708
Change gettext-win base to 0.18 (master is 1.0 now)
crazywhalecc 3eca044
Whoops
crazywhalecc 7bb4a09
turn llvm-tools into a doctor check. llvm-runtime is a target now
henderkes efa7946
build in SOURCE_PATH
henderkes b38c7b2
install runtime rt after zig init
henderkes 433043c
fix macOS
henderkes f1525c0
Merge branch 'v3' into feat/pgo-v3
henderkes 6fe55a4
Merge branch 'v3' into feat/pgo-v3
crazywhalecc 735f126
Update discord invite link
crazywhalecc a23ad55
Add preInstall stage
crazywhalecc 9d508f1
forward port v2 pgo changes
henderkes c40d069
address #1155
henderkes d93fdd9
use github tokens for package downloads
henderkes 3c24c92
mongodb: export PHP_VERSION_ID for in-tree builds
luthermonson 713f825
mongodb: export PHP_VERSION_ID for in-tree builds (#1156)
henderkes e7fb1e2
backport fixes from v2
henderkes 1ae989d
simplify common zig code paths
henderkes 203fed6
dont pass shared extension packages to SPCConfigUtil for building php…
henderkes 5bdcd3f
dont pass all static exts to frankenphp build either
henderkes 6ab52a5
cxxflags in spcconfigutil
henderkes 80d8107
backport v2 passing correct libraries, not all
henderkes fe4803c
run shared ext builds after frankenphp build
henderkes 15deecd
Merge remote-tracking branch 'origin/v3' into feat/pgo-v3
henderkes f068911
revert
henderkes d846db2
forward v2 fix
henderkes 69d0f9b
remove SPC_ARCH
henderkes 2d5abd3
micro patch for cross-arch 32 bit builds
henderkes d52ba59
fix SourcePatcher::patchHardcodedINI method signature
henderkes 5747a56
build shared extensions before frankenphp
henderkes 3b8abda
add libclang.cpu.a
henderkes 8f557aa
forward-port feat/pgo fixes
henderkes 6b6a099
fix gmssl and event properly..
henderkes a65441b
dont pass invalid empty gh token
henderkes 6060a6c
blub
henderkes 404b2dc
fix smth
henderkes 1778032
fix swoole trying to load under fpm/frankenphp
henderkes 9bceaac
update extensions from pecl to pie
henderkes 15e2b7b
simpler fix for swoole
henderkes b437b2f
default extract for pie sources
henderkes 0299ed5
default extract for pie source number 2
henderkes 81213f5
extract shared-only extensions into their own folder
henderkes 6ba9cd2
pecl for those
henderkes ed0863d
imagick on pecl too, version substitute...
henderkes 347a3c3
move opentelemetry back to PIE
henderkes 3b425b6
igbinary PIE
henderkes 3bd142a
extra ldflags Libphp.so
henderkes 02df4a2
Update ext-event.yml
henderkes a5a8d0e
php 8.6 compatibility with all bundled extensions
henderkes 38ad355
test: use source.build-root in getSourceRoot test
henderkes de3ee11
more fixes for 8.6
henderkes 600d08e
more fixes for 8.6
henderkes 657960d
update php-rar
henderkes 341d82d
php 8.6.0~beta1 compatibility
henderkes 497ebae
php 8.6.0~beta1 compatibility 2
henderkes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| ext-fastchart: | ||
| type: php-extension | ||
| artifact: | ||
| source: | ||
| type: ghtar | ||
| repo: iliaal/fastchart | ||
| extract: php-src/ext/fastchart | ||
| prefer-stable: true | ||
| metadata: | ||
| license-files: [LICENSE] | ||
| depends: | ||
| - freetype | ||
| suggests: | ||
| - libpng | ||
| - libjpeg | ||
| - libwebp | ||
| php-extension: | ||
| os: | ||
| - Linux | ||
| - Darwin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| ext-fastjson: | ||
| type: php-extension | ||
| artifact: | ||
| source: | ||
| type: ghtar | ||
| repo: iliaal/fastjson | ||
| extract: php-src/ext/fastjson | ||
| prefer-stable: true | ||
| metadata: | ||
| license-files: [LICENSE] | ||
| php-extension: | ||
| os: | ||
| - Linux | ||
| - Darwin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,3 +10,5 @@ ext-gmssl: | |
| license: PHP-3.01 | ||
| depends: | ||
| - gmssl | ||
| php-extension: | ||
| arg-type: with-path | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
subdir?build-rootis definitely ambiguous. Also, move all the previousmetadata.source-roothere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-dir?
subdir doesn't say what that directory is used for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep using source-root? build-dir sounds ambiguous too (out-of-source building). The name
source-rootalso corresponds to our APIgetSourceRoot(). Although it still doesn't accurately describe our needs, it essentially redirects the source root.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two diffrremt things, we need both of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another approach is to completely redirect everything using source-root, eliminating the need to worry about subdirectories during in-tree extension builds:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After doing this, our previous source-root and the current source-root for PHP extensions are actually the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that doesn't have edge cases with extension configs resolving to absolute paths before? If it's working with all extensions I think that's a good idea.