feat(glossaries): add multi-value term filters and exportType to Export Glossary - #261
Open
innomaxx wants to merge 1 commit into
Open
feat(glossaries): add multi-value term filters and exportType to Export Glossary#261innomaxx wants to merge 1 commit into
innomaxx wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the glossaries API resource types and tests to support the newly expanded Export Glossary request shape described in issue #257 (multi-value term filters plus exportType control).
Changes:
- Added new export-related enums (export type and term filter enums) for glossary export requests.
- Extended the
GlossarySchemaRequestTypedDict to include new export request fields (multi-value filters andexportType). - Expanded glossaries resource tests to cover the new request fields passed to
export_glossary.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crowdin_api/api_resources/glossaries/types.py |
Extends the export glossary request typing to include new export filters and exportType. |
crowdin_api/api_resources/glossaries/tests/test_glossaries_resources.py |
Adds a new test case exercising the updated export glossary request payload. |
crowdin_api/api_resources/glossaries/enums.py |
Introduces new enums representing export type and multi-value term filter values for glossary export. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
24
to
+33
| class GlossarySchemaRequest(TypedDict): | ||
| format: Optional[GlossaryFormat] | ||
| exportFields: Optional[Iterable[GlossaryExportFields]] | ||
| exportType: Optional[GlossaryExportType] | ||
| statuses: Optional[Iterable[GlossaryExportStatus]] | ||
| partsOfSpeech: Optional[Iterable[GlossaryExportPartOfSpeech]] | ||
| types: Optional[Iterable[GlossaryExportTermType]] | ||
| genders: Optional[Iterable[GlossaryExportGender]] | ||
| authorIds: Optional[Iterable[int]] | ||
| languageIds: Optional[Iterable[str]] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257