feat(ai): remove assist action and add context fields - #265
Open
innomaxx wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the AI resource type system and tests to match recent Crowdin/Crowdin Enterprise API changes by removing the deprecated assist action and introducing new context/config fields for prompt configuration and prompt-completion requests.
Changes:
- Removed
assistfromAIPromptActionand removed the related settings patch path enum value. - Updated AI prompt basic-mode typing to support
projectContext(andorganizationContext) and added new basic-mode config types foralignmentandqa_check. - Extended prompt-completion context resources to include
projectDescription, and updated unit tests accordingly.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crowdin_api/api_resources/ai/types.py |
Removes assist-related types, adds alignment/qa_check config types and new context fields for AI prompt configs and completion resources. |
crowdin_api/api_resources/ai/tests/test_ai_resources.py |
Updates test fixtures and request-serialization expectations for new actions and added context fields; removes assist-related test cases. |
crowdin_api/api_resources/ai/enums.py |
Removes ASSIST action + assist settings patch path; adds ALIGNMENT and QA_CHECK actions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
81
to
+84
| config: Union[ | ||
| BasicModePreTranslateActionCondfig, | ||
| BasicModeAssistActionCondfig, | ||
| BasicModeAlignmentActionConfig, | ||
| BasicModeQaCheckActionConfig, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258