chore: nixfmt-rfc-style -> nixfmt

[csamuel]

Fixes this warning during evaluation

evaluation warning: nixfmt-rfc-style is now the same as pkgs.nixfmt
which should be used instead.

Summary by CodeRabbit

• Documentation

  • Added mfourmax to the list of supported hosts.

• Chores

  • Updated the default code formatter from nixfmt-rfc-style to nixfmt across development environments and configuration files.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR replaces the nixfmt-rfc-style formatter with nixfmt across development configuration and documentation, and adds mfourmax to the documented list of known hosts. All changes are configuration and documentation updates with no logic modifications.

Changes

Cohort / File(s)	Summary
Documentation Updates AGENTS.md	Updated Project Structure and Quick Reference sections to reflect nixfmt (instead of nixfmt-rfc-style) as the primary formatter; added mfourmax to the current hosts list.
Development Configuration flake.nix, home-manager/default.nix	Replaced nixfmt-rfc-style with nixfmt in development shell package declarations and formatter configurations for both aarch64-darwin and x86_64-linux platforms.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A formatter swap, so neat and clean,
From RFC-style to standard scene,
With mfourmax hopping into view,
The tools are fresh, the config's new! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'chore: nixfmt-rfc-style -> nixfmt' accurately summarizes the main change - replacing nixfmt-rfc-style with nixfmt across multiple files to address an evaluation warning.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[claude]

Pull Request Review: chore: nixfmt-rfc-style -> nixfmt

Summary

This PR addresses a deprecation warning by replacing nixfmt-rfc-style with nixfmt across the codebase. The change is appropriate and aligns with the nixpkgs ecosystem evolution where nixfmt now refers to the RFC-style formatter.

Code Quality ✅

• Consistent changes: All instances of nixfmt-rfc-style have been correctly replaced with nixfmt
• Scope: Changes are appropriately limited to:
  • Development shell packages (flake.nix:60)
  • Formatter definitions for both aarch64-darwin and x86_64-linux (flake.nix:96, 100)
  • Home-manager user packages (home-manager/default.nix:29)
• No functional changes: This is purely a rename with no behavior modifications

Best Practices ✅

• Commit message: Follows conventional commit format with chore: prefix
• Atomic change: Single-purpose PR focused on one deprecation fix
• Cross-platform: Correctly updates both darwin and linux formatter configurations

Potential Issues ⚠️

1. Documentation inconsistency: The CLAUDE.md file should be updated to reflect this change:

   • Line 32: Still references "RFC-style formatting (nixfmt-rfc-style)"
   • Line 65: Lists "Primary formatter: nixfmt-rfc-style"

   These should be updated to just nixfmt for consistency.

Testing Recommendations 🧪

Before merging, please verify:

1. ✅ Run treefmt --ci to ensure formatting still works
2. ✅ Run nix flake check --keep-going --print-build-logs to verify the flake evaluates correctly
3. ✅ Confirm the deprecation warning no longer appears during evaluation
4. ✅ Test that nix develop shell includes the correct formatter

Security Concerns ✅

No security implications - this is a package rename within the same nixpkgs ecosystem.

Performance ✅

No performance impact - nixfmt is now an alias/replacement for nixfmt-rfc-style, same underlying implementation.

Suggestions

1. Update CLAUDE.md: Consider updating the project documentation in a follow-up commit or as part of this PR to match the new package name.

Overall Assessment: APPROVE ✅

This is a straightforward, necessary maintenance change that resolves a deprecation warning. The changes are correct and complete for the code itself. The only minor issue is the documentation inconsistency in CLAUDE.md, which can be addressed either in this PR or a follow-up.

Great job keeping the codebase up-to-date with nixpkgs changes!

[Copilot]

Pull request overview

This PR updates deprecated package references from nixfmt-rfc-style to nixfmt to resolve an evaluation warning. The nixfmt-rfc-style package has been merged with pkgs.nixfmt, making the old name redundant.

Changes:

• Replaced all nixfmt-rfc-style references with nixfmt in Nix configuration files
• Updated package references in home-manager configuration and flake devShell
• Updated formatter definitions for both aarch64-darwin and x86_64-linux platforms

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
home-manager/default.nix	Updated nixfmt-rfc-style to nixfmt in home packages list
flake.nix	Updated nixfmt-rfc-style to nixfmt in devShell packages and formatter definitions for both architectures

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

AGENTS.md (1)

6-20: Keep the “Apply changes” host list in sync.

mfourmax is added to the host list above, but the “Apply changes” line still omits it. That’s likely to confuse users.

📌 Suggested doc tweak

-- **Apply changes**: `sudo darwin-rebuild switch --flake .#<host>` (hosts: higgins, benson, spaceblack, dunston)
+- **Apply changes**: `sudo darwin-rebuild switch --flake .#<host>` (hosts: higgins, benson, spaceblack, dunston, mfourmax)