-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: darwin modules and add explicit flake checks #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
257cee4
c00c4ad
a590ba7
f74418d
6b1c9e2
6ff1856
276d166
9b37e41
f6e5613
3eac957
e5bac57
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| "$schema" = 'https://starship.rs/config-schema.json' | ||
|
|
||
| format = """ | ||
| [░▒▓](#a3aed2)\ | ||
| [ ](bg:#a3aed2 fg:#090c0c)\ | ||
| [](bg:#769ff0 fg:#a3aed2)\ | ||
| $directory\ | ||
| [](fg:#769ff0 bg:#394260)\ | ||
| $git_branch\ | ||
| $git_status\ | ||
| [](fg:#394260 bg:#212736)\ | ||
| $fill\ | ||
| $nodejs\ | ||
| $rust\ | ||
| $python\ | ||
| $pulumi\ | ||
| $golang\ | ||
| $nix_shell\ | ||
| \n$character""" | ||
|
|
||
| [directory] | ||
| style = "fg:#e3e5e5 bg:#769ff0" | ||
| truncate_to_repo = true | ||
| format = "[ $path ]($style)" | ||
| truncation_length = 3 | ||
| truncation_symbol = "…/" | ||
|
|
||
| [fill] | ||
| symbol = ' ' | ||
|
|
||
| [pulumi] | ||
| format = '[$symbol$stack]($style) ' | ||
|
|
||
| [git_branch] | ||
| symbol = "" | ||
| style = "bg:#394260" | ||
| format = '[[ $symbol $branch ](fg:#769ff0 bg:#394260)]($style)' | ||
|
|
||
| [git_status] | ||
| style = "bg:#394260" | ||
| format = '[[($all_status$ahead_behind )](fg:#769ff0 bg:#394260)]($style)' | ||
|
|
||
| [nodejs] | ||
| symbol = "" | ||
| style = "bg:#212736" | ||
| format = '[[ $symbol ($version) ](fg:#769ff0 bg:#212736)]($style)' | ||
|
|
||
| [rust] | ||
| symbol = "" | ||
| style = "bg:#212736" | ||
| format = '[[ $symbol ($version) ](fg:#769ff0 bg:#212736)]($style)' | ||
|
|
||
| [golang] | ||
| symbol = "" | ||
| style = "bg:#212736" | ||
| format = '[[ $symbol ($version) ](fg:#769ff0 bg:#212736)]($style)' | ||
|
|
||
| [nix_shell] | ||
| symbol = '❄️' | ||
| format = '[$symbol $state]($style) ' |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,39 @@ | ||
| // Zed settings | ||
| // | ||
| // For information on how to configure Zed, see the Zed | ||
| // documentation: https://zed.dev/docs/configuring-zed | ||
| // | ||
| // To see all of Zed's default settings without changing your | ||
| // custom settings, run `zed: open default settings` from the | ||
| // command palette (cmd-shift-p / ctrl-shift-p) | ||
| { | ||
| "icon_theme": "VSCode Icons (Dark)", | ||
| { | ||
| "assistant": { | ||
| "context_servers": { | ||
| "mcp-server-github": { | ||
| "source": "extension", | ||
| "enabled": true, | ||
| "settings": {} | ||
| } | ||
| }, | ||
| "icon_theme": "VSCode Icons for Zed (Dark Official Icons)", | ||
| "agent": { | ||
| "inline_assistant_model": { | ||
| "provider": "zed.dev", | ||
| "model": "claude-sonnet-4-latest" | ||
| }, | ||
| "default_model": { | ||
| "provider": "google", | ||
| "model": "gemini-2.5-pro-exp-03-25" | ||
| "provider": "zed.dev", | ||
| "model": "claude-sonnet-4-thinking" | ||
| }, | ||
| "always_allow_tool_actions": true, | ||
| "default_profile": "write", | ||
| "version": "2" | ||
| } | ||
| } | ||
| "default_profile": "write" | ||
| }, | ||
| "features": { | ||
| "edit_prediction_provider": "zed" | ||
| }, | ||
| "ui_font_size": 16, | ||
| "buffer_font_size": 17.0, | ||
| "buffer_font_size": 12.0, | ||
| "buffer_font_family": "MesloLGS Nerd Font Mono", | ||
| "theme": { | ||
| "mode": "system", | ||
| "light": "One Light", | ||
| "dark": "Tokyo Night Storm" | ||
| }, | ||
| "agent_servers": { | ||
| "OpenCode": { | ||
| "command": "opencode", | ||
| "args": ["acp"] | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| { ... }: | ||
|
|
||
| { | ||
| profiles = { | ||
| audio.enable = true; | ||
| gaming.enable = true; | ||
| photography.enable = true; | ||
| video.enable = true; | ||
| }; | ||
| imports = [ | ||
| ./shared/media.nix | ||
| ./shared/gaming.nix | ||
| ]; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,13 @@ | ||
| { pkgs, lib, ... }: | ||
| { ... }: | ||
|
|
||
| { | ||
| profiles = { | ||
| audio.enable = true; | ||
| gaming.enable = true; | ||
| photography.enable = true; | ||
| video.enable = true; | ||
| }; | ||
| imports = [ | ||
| ./shared/media.nix | ||
| ./shared/gaming.nix | ||
| ]; | ||
|
|
||
| fonts.packages = lib.mkAfter [ pkgs.nerd-fonts.fira-code ]; | ||
| wallpaper = { | ||
| enable = true; | ||
| image = ../../wallpapers/deeptwilight.png; | ||
| }; | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,8 @@ | ||
| { ... }: | ||
|
|
||
| { | ||
| profiles = { | ||
| audio.enable = true; | ||
| gaming.enable = true; | ||
| photography.enable = true; | ||
| video.enable = true; | ||
| }; | ||
| imports = [ | ||
| ./shared/media.nix | ||
| ./shared/gaming.nix | ||
| ]; | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,10 @@ | ||||||
| { pkgs, lib, ... }: | ||||||
| { ... }: | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use the standard explicit signature form here too. Line 1 should follow the repo’s destructured function signature convention. Suggested change-{ ... }:
+{ pkgs, lib, config, ... }:As per coding guidelines: Use attribute sets with destructuring in function signatures: 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| { | ||||||
| fonts.packages = lib.mkAfter [ pkgs.nerd-fonts.fira-code ]; | ||||||
|
|
||||||
| wallpaper = ../../wallpapers/deeptwilight.png; | ||||||
| wallpaper = { | ||||||
| enable = true; | ||||||
| image = ../../wallpapers/deeptwilight.png; | ||||||
| }; | ||||||
|
|
||||||
| dock.extraApps = [ | ||||||
| "/Applications/Figma.app" | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { ... }: | ||
|
|
||
| { | ||
| profiles.gaming.enable = true; | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,9 @@ | ||||||
| { ... }: | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Align module signature with repo convention. Line 1 should use explicit destructuring instead of Suggested change-{ ... }:
+{ pkgs, lib, config, ... }:As per coding guidelines: Use attribute sets with destructuring in function signatures: 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| { | ||||||
| profiles = { | ||||||
| audio.enable = true; | ||||||
| photography.enable = true; | ||||||
| video.enable = true; | ||||||
| }; | ||||||
| } | ||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,3 @@ | ||||||
| { pkgs, lib, ... }: | ||||||
| { ... }: | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Use explicit module arg destructuring for host modules. Line 1 currently uses Suggested change-{ ... }:
+{ pkgs, lib, config, ... }:As per coding guidelines: Use attribute sets with destructuring in function signatures: 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| { | ||||||
| fonts.packages = lib.mkAfter [ pkgs.nerd-fonts.fira-code ]; | ||||||
| } | ||||||
| { } | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| config, | ||
| lib, | ||
| ... | ||
| }: | ||
|
|
||
| let | ||
| cfg = config.determinateNix; | ||
| trustedUsers = lib.concatStringsSep " " cfg.trustedUsers; | ||
| in | ||
| { | ||
| options.determinateNix = { | ||
| enable = lib.mkEnableOption "Determinate Nix compatibility tweaks"; | ||
|
|
||
| trustedUsers = lib.mkOption { | ||
| type = lib.types.listOf lib.types.str; | ||
| default = [ config.system.primaryUser ]; | ||
| description = "Users that should be written to /etc/nix/nix.custom.conf."; | ||
| }; | ||
| }; | ||
|
|
||
| config = lib.mkIf cfg.enable { | ||
| system.activationScripts.determinateNix.text = '' | ||
| if [ -f /etc/nix/nix.custom.conf ]; then | ||
| tmp="$(mktemp)" | ||
| grep -Ev '^[[:space:]]*trusted-users[[:space:]]*=.*$' /etc/nix/nix.custom.conf > "$tmp" || true | ||
| echo "trusted-users = root ${trustedUsers}" >> "$tmp" | ||
| mv "$tmp" /etc/nix/nix.custom.conf | ||
| fi | ||
| ''; | ||
| }; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { ... }: | ||
|
|
||
| { | ||
| homebrew.casks = [ | ||
| "font-bitstream-vera-sans-mono-nerd-font" | ||
| "font-fira-code-nerd-font" | ||
| "font-hack-nerd-font" | ||
| "font-meslo-lg-nerd-font" | ||
| ]; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep host module signatures explicit.
Line 1 uses
{ ... }:; please use explicit destructuring per repo convention.Suggested change
As per coding guidelines: Use attribute sets with destructuring in function signatures:
{ pkgs, lib, config, ... }:.📝 Committable suggestion
🤖 Prompt for AI Agents