fix: make DemoZoo favorites loadable and export-aware - #296
Open
anomixer wants to merge 14 commits into
Open
Conversation
# Conflicts: # CHANGELOG.md # src/ui/devices/disk/demozoodialog.tsx # src/ui/devices/disk/diskdrive.tsx # src/ui/devices/disk/driveprops.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This follow-up fixes DemoZoo productions after they have been added to Favorites.
A DemoZoo production could be loaded successfully from the DemoZoo dialog, but the same item could fail to boot when
selected later from the Favorites collection. Favorites also did not consistently show the correct DemoZoo identity or
disk export status.
Changes
DEMOZOOcollection items instead of Internet Archive items.Tested
Tested locally with:
Also tested with the Cloudflare Pages deployment.
Test cases included:
Some DemoZoo productions only provide YouTube or other external links. Those productions cannot be booted as disk images and continue to open the external link instead.
This PR is a follow-up to the DemoZoo integration merged in PR #293.