Add Player channel inspector - #46
Draft
HomeDCP wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #45.
This adds a monitor-only channel inspector to DCP-o-matic Player:
Tools > Channel inspector...in Player.I kept global EQ out of scope, following the discussion on the issue.
Notes
The inspector is implemented as a Player-only floating frame. When opened,
FilmViewerrecreates the playback Butler with an identity DCP-channel mapping so each DCP channel can be inspected before the normal output-device mapping is applied. Closing the inspector restores the normal playback path.The monitor path intentionally matches the existing
remap()behavior by applying only positive configured gains. Unmapped channels are displayed as unmapped and their Solo/Mute controls are disabled.Validation
Tested locally on macOS:
./waf configure --c++17 --disable-testspassed../waf buildpassed and linkedbuild/src/tools/dcpomatic2_player../waf configure --c++17passed with tests enabled../waf build --targets=unit-testspassed, including compile oftest/channel_inspector_test.ccand link ofbuild/test/unit-tests.src/wx/channel_inspector.hpassed, and the smoke executable exited 0.I could not run the selected official Boost test cases in this checkout because
test/datais a submodule pointing tocth103/dcpomatic-test-data.git, which was not accessible from my environment. The new focused unit test is included and compiles in theunit-teststarget.