Guard delayed document initialization against empty paragraph state - #50
Open
tobitege wants to merge 1 commit into
Open
Guard delayed document initialization against empty paragraph state#50tobitege wants to merge 1 commit into
tobitege wants to merge 1 commit into
Conversation
tobitege
marked this pull request as ready for review
July 29, 2026 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
InitializeDocument()posts work atDispatcherPriority.Background. The callback previously accessed the first paragraph with[0], relying on state that was valid when the work was scheduled. A host can clear or replaceFlowDocument.Blocksbefore the dispatcher executes the callback, leaving the paragraph collection empty and causing anArgumentOutOfRangeExceptionfrom the dispatcher.Fix
Use
FirstOrDefault()inside the delayed callback and run the focus/layout initialization only when a paragraph still exists. If the document state has already been replaced, the obsolete initialization work becomes a no-op.Validation
dotnet build AvRichTextBox.slncompleted with 0 errors.DemoApp_AvRichTextBox. Its loaded path clears and replacesFlowDocument.Blocksafter control initialization; the application remained responsive and rendered the replacement paragraph and table.