Remove scribejava-core dependency; implement OAuth 1.0a directly#9
Open
renatoathaydes wants to merge 1 commit into
Open
Remove scribejava-core dependency; implement OAuth 1.0a directly#9renatoathaydes wants to merge 1 commit into
renatoathaydes wants to merge 1 commit into
Conversation
Replace the scribejava-core based OAuth client with a self-contained implementation built on the Curity SDK's WebServiceClient/HttpClient and Json services. - Add TwitterOAuthClient implementing the Twitter OAuth 1.0a (3-legged) flow with HMAC-SHA1 request signing and RFC 3986 percent-encoding. - Parse Twitter's form-encoded token responses; use the SDK Json service to extract messages from Twitter's JSON error responses. - Delete the scribejava glue: ScribeJavaHttpClientAdapter, TwitterApi and HttpClientUtil. - Rewrite TwitterAuthenticatorRequestHandler and CallbackRequestHandler to use TwitterOAuthClient. - Expose the Json service via TwitterAuthenticatorPluginConfig#getJson. - Drop the scribejava-core dependency from pom.xml; update README as the plugin now has no third-party runtime dependencies. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the scribejava-core based OAuth client with a self-contained implementation built on the Curity SDK's WebServiceClient/HttpClient and Json services.