Skip to content

Fix tests for buffermgr trait - #29

Open
cutsea110 wants to merge 1 commit into
masterfrom
fix-tests-for-buffermgr-trait
Open

Fix tests for buffermgr trait#29
cutsea110 wants to merge 1 commit into
masterfrom
fix-tests-for-buffermgr-trait

Conversation

@cutsea110

@cutsea110 cutsea110 commented Jun 24, 2022

Copy link
Copy Markdown
Owner

BufferMgr + Send fixes test.

@cutsea110

cutsea110 commented Jun 24, 2022

Copy link
Copy Markdown
Owner Author

We need to add Send trait for BufferMgr.
But, app program does not need this. Something is wrong.

@cutsea110

cutsea110 commented Jun 24, 2022

Copy link
Copy Markdown
Owner Author

There are some possibilities like as below.

  1. this isn't unnecessary trait, so the test code is wrong.
  2. this is necessary fix. and app code is not good.

@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch from 3193a47 to 94800a0 Compare June 25, 2022 00:49
@cutsea110 cutsea110 mentioned this pull request Jun 25, 2022
Merged
@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch 6 times, most recently from 7f8bdb9 to bb23836 Compare July 6, 2022 00:13
@cutsea110 cutsea110 self-assigned this Jul 6, 2022
@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch 6 times, most recently from b85a5eb to 916d5e7 Compare July 12, 2022 12:20
@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch 6 times, most recently from 426c659 to 01cc870 Compare July 20, 2022 12:35
@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch 2 times, most recently from 7e05599 to 89b6160 Compare July 28, 2022 21:11
@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch from 89b6160 to 7990c54 Compare July 29, 2022 09:21
@cutsea110
cutsea110 force-pushed the fix-tests-for-buffermgr-trait branch from 7990c54 to 4e6ec72 Compare August 10, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cutsea110 cutsea110

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cutsea110