fix(devin): use decision "reject" and remove sentinel no-op - #62
Merged
Conversation
The no-op sentinel/sidecar workaround was needed because `decision: "block"` stops the agent turn. Devin CLI's hook decision enum supports "reject", which rejects the tool call while allowing the loop to continue. Remove PostToolUse and the sidecar entirely. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decision: "reject"from the PreToolUse hook.post-tool-use.ts,post-tool-use.test.ts, and all PostToolUse hook wiring.pre-tool-use.tsto emit{"decision": "reject", "reason": "..."}and exit 0 when a gate violation is detected.settings-writer.ts,install-devin.ts,run.mjs, andhooks.jsonto only install PreToolUse and SessionStart hooks.pre-tool-use.test.ts,settings-writer.test.ts, andcli.test.tsto assert the reject behavior and verify PostToolUse is no longer written.system-prompt.template.mdto describe the rejection behavior and remove PostToolUse examples.package.json,package-lock.json, and.devin-plugin/plugin.json.Test plan
npm run checkpassesnpm run testpasses (405 tests)Generated with Devin