fix(module-interface-import): block export-from, dynamic import, .js fallback, and directory index - #63
Merged
Merged
Conversation
…fallback, and directory index resolution
The Devin pre-tool-use hook was not blocking imports from specific
files in several edge cases:
- export { x } / export * from '../module/file'
- await import('../module/file')
- import { x } from '../module/file.js' resolving to a .ts file
- import { x } from '../module' resolving to module/index.ts
Update the regex in extractJsImportPaths to also match export-from and
import() patterns, and refactor resolveRelativeImport to fall back
through JS/TS extensions and directory index files.
Bump version to 1.1.3.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractJsImportPathsnow also matchesexport ... fromre-exports and dynamicimport()calls.resolveRelativeImportnow falls back through JS/TS extensions when an explicit extension (e.g..js) does not exist, and resolves extensionless directory imports toindex.ts/index.js/mod.rs.export { } from,export * from, dynamicimport(),.jsextension fallback, and directory index resolution.Test plan
npm run checkpassesnpm run testpassesGenerated with Devin