Skip to content

improve: [1120] キーコンフィグ画面のKeyLockボタンの説明文を追加、KeyLockボタンの位置調整#2156

Merged
cwtickle merged 2 commits into
developfrom
feature/1120-key-assign-msg
Jun 21, 2026
Merged

improve: [1120] キーコンフィグ画面のKeyLockボタンの説明文を追加、KeyLockボタンの位置調整#2156
cwtickle merged 2 commits into
developfrom
feature/1120-key-assign-msg

Conversation

@cwtickle

@cwtickle cwtickle commented Jun 21, 2026

Copy link
Copy Markdown
Owner

🔨 変更内容 / Details of Changes

1. キーコンフィグ画面のKeyLockボタンの説明文を追加

2. キーコンフィグ画面のKeyLockボタンの位置調整

  • 横幅が狭い場合にカラーグループボタンと重なる可能性があったため、位置調整しました。

🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes

  1. 変更内容を画面から確認できるようにするため。
  2. レイアウト上の問題が発生する可能性があるため。

📷 スクリーンショット / Screenshot

image

📝 その他コメント / Other Comments

@cwtickle cwtickle added the func11:KeyConfig キーコンフィグ、キー定義関係 label Jun 21, 2026
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a keyLock message string to both the Japanese and English locale message objects in danoni_constants.js, describing the KeyLock toggle behavior. The btnKcKeyLock button in the key-config UI is then assigned this new string as its title tooltip attribute.

Changes

KeyLock Tooltip Wiring

Layer / File(s) Summary
keyLock locale strings and button tooltip
js/lib/danoni_constants.js
Adds keyLock entries to both Japanese (g_lang_lblNameObj) and English locale message objects, and assigns g_msgObj.keyLock as the title tooltip on btnKcKeyLock in the key-config layout.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • cwtickle/danoniplus#2155: Modifies the same btnKcKeyLock UI element and g_msgObj.keyLock locale string entries in js/lib/danoni_constants.js.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main changes: adding explanatory text to the KeyLock button and adjusting its position in the key configuration screen.
Description check ✅ Passed The pull request description clearly relates to the changeset by explaining the addition of explanatory text for the KeyLock button and position adjustments.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/1120-key-assign-msg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cwtickle cwtickle changed the title improve: [1120] キーコンフィグ画面のKeyLockボタンの説明文を追加 improve: [1120] キーコンフィグ画面のKeyLockボタンの説明文を追加、KeyLockボタンの位置調整 Jun 21, 2026
@cwtickle cwtickle added the Layout Changes ラベルやボタンなどのレイアウト変更を伴う修正 label Jun 21, 2026
@cwtickle cwtickle merged commit bdb95ed into develop Jun 21, 2026
4 checks passed
@cwtickle cwtickle deleted the feature/1120-key-assign-msg branch June 22, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

func11:KeyConfig キーコンフィグ、キー定義関係 Layout Changes ラベルやボタンなどのレイアウト変更を伴う修正

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant