feat: [1122] 譜面名の複数行・リサイズ対応#2157
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesMulti-line font sizing helpers and callsites
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.0)js/danoni_main.jsThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@js/danoni_main.js`:
- Around line 1518-1520: The code uses hard-coded space character checks (`' '`)
instead of using the `delim` parameter that is part of the function contract,
causing the function to ignore custom delimiters. Replace the direct comparison
`_targetStr[j] === ' '` with a comparison using the `delim` variable in the loop
starting at halfIndex (around line 1519), and also apply the same fix to the
similar check mentioned at line 1528-1530. This ensures the function respects
the delimiter option passed by the caller.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
🔨 変更内容 / Details of Changes
1. 譜面名の複数行・リサイズ対応
🔖 関連Issue, 変更理由 / Related Issues, Reason for Changes
設定画面のヘルプボタンにより譜面名がボタンに重なる可能性があったため。
📷 スクリーンショット / Screenshot
📝 その他コメント / Other Comments