Fix crash bugs, wrong output bugs, release pipeline, and test coverage#5
Merged
Conversation
- Fixed it.only in csharp-util.test.ts that was skipping 42 tests - Added 24 new tests covering cleanAccessor, convertEndOfLine, checkIfAlreadyPulledToInterface, cleanAllAccessors, SignatureLineResult.createFromSignatureLineResult, preSignatureContent paths, getSignatureToPull, addUsingsToDocument, and addMemberToDocument edge cases - Added testFileWithAttribute fixture for attribute/XML doc comment tests - Added @vscode/vsce devDependency - Added keywords and cleaned up categories in package.json for marketplace discoverability - Added GitHub Actions release workflow to publish to VS Code Marketplace on release - Added CLAUDE.md with build/test commands and architecture overview Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Initialize preSignatureContent to [] in SignatureLineResult constructor to prevent TypeError on .length access - Add lineCount bounds check in getFullSignatureOfLine forward scan to prevent RangeError at end of document - Replace while(true) with while(preSignatureStartingLine >= 0) to prevent RangeError when cursor is near top of file - Add lineCount bounds checks in getMemberBodyByBrackets and getMemberBodyBySemiColon loops Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Strip async keyword from method signatures when pulling to interface
- Detect readonly properties ({ get; }) via originalSelectedLine and use { get; } instead of { get; set; }
- Add word boundary (\b) to base class regex so 'Base' no longer matches 'BaseClass'
- Apply indentation to base class insertions using same padStart logic as interface path
- Add failing tests proving each bug before fixing
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Generated with Claude Code