meta: add assert_computable, synced from ironwood - #8
Merged
Conversation
A build check for computed reductions: the declaration must be a plain def — an actual definition, not marked noncomputable — with axioms bounded by propext / Quot.sound. +choice permits Classical.choice, which with the plain-def check asserts choice enters only through erased Prop fields. +native permits native_decide compiler-trust axioms. The plain-def check catches a def being marked noncomputable later, which would otherwise build and silently void a computed-reduction convention. Ported verbatim from ironwood's Zcash/Meta/AxiomCheck.lean; the module docstrings on both sides say to keep the two files in sync. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
daira
marked this pull request as ready for review
July 19, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports
assert_computablefrom ironwood'sZcash/Meta/AxiomCheck.lean, keeping the two shared macro files in sync per their module docstrings: a build check that a declaration is a plaindef(not a theorem, not markednoncomputable) with axioms bounded bypropext/Quot.sound, with+choiceand+nativeopt-ins. CompElliptic has no computed-reduction defs yet, so no census changes here.🤖 Claude Fable 5