Fix Options UI saving runtime keys instead of persisted default config keys#70
Merged
Merged
Conversation
Owner
|
Looks good to me. I've been wanting to fix the settings for a while but lately I'm not having much time, this is really appreaciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several Options UI settings that were being saved under their runtime/UI key names instead of the persisted default config keys used when the application starts.
Some shared UI builders return components keyed by runtime names such as in_offload_to_cpu, in_preview_mode, or environment-specific names such as env_GGML_VK_VISIBLE_DEVICES. These names are useful for generation/runtime parameter collection, but the Options page was registering some of them directly as config keys.
As a result, changing some settings from the Options page could appear to work during the current session, but after restarting the application the UI would reload from the corresponding def_* config key and ignore the saved value.
Changes
Options changed through the UI are now saved to the same config keys that are read when the application starts, so settings persist correctly after restart.