Adopt the regex! macro

[danieldickison]

Summary

• replace all three reusable Rust regex singletons with regex!
• expose the player-name regex through a shared accessor and use Regex::as_str() for the HTML validation pattern
• replace the SumoDB builder option with the equivalent inline (?s) flag
• remove all regex-related LazyLock and RegexBuilder boilerplate

This PR is stacked on #164 because regex! was introduced in regex 1.13.0.

Two unrelated LazyLock uses remain for the JST offset and SUMO_API_DRY_RUN; LazyLock is provided by the standard library rather than a Cargo dependency.

Validation

• cargo test --locked
• cargo clippy --locked --all-targets -- -D warnings

[Copilot]

Pull request overview

This PR refactors reusable Rust regex singletons to use the new regex! macro (regex 1.13.0), reducing LazyLock/RegexBuilder boilerplate while keeping the existing validation and parsing behavior.

Changes:

• Replaced regex LazyLock singletons with regex! call sites for player-name validation, SQLite trace normalization, and SumoDB HTML parsing.
• Exposed the player-name regex via a shared accessor and used Regex::as_str() in the settings form’s HTML pattern.
• Replaced the SumoDB builder option (dot_matches_new_line) with the inline (?s) flag.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
templates/settings.html	Uses the shared Rust player-name regex pattern string for HTML input validation.
src/handlers/admin.rs	Switches the SumoDB parsing regex from LazyLock/RegexBuilder to an inline regex! call with (?s).
src/data/player.rs	Replaces the player-name regex singleton with name_regex() backed by regex! and updates validation to use it.
src/data/mod.rs	Replaces debug SQLite trace whitespace-normalization singleton with an inline regex! call.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.