test: deflake j/k navigation e2e by asserting the active file - #31
Merged
Conversation
The test compared raw scrollY offsets around the two j presses, but the PR description above the diff renders asynchronously and shifts every section down, so the second j could re-anchor the first file and k then had nowhere to go (k from the first file is a no-op by design). Assert the scroll spy's active file in the tree instead, retrying the keypress until the spy reports the expected file. Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
j and k scroll between filese2e compared rawscrollYoffsets around the twojpresses. The PR description above the diff renders asynchronously and shifts every section down, so between the presses the secondjcould re-anchor the file it was already on — andkfrom the first file is a no-op by design, leavingscrollYstuck at the captured offset until the poll timed out (failure in CI).Assert the scroll spy's active file in the tree (
.pt-tree-file.pt-activedata-path) instead of pixel offsets, retrying the keypress until the spy reports the expected file. The scroll assertions that remain only check direction, not exact offsets.Verified with
--repeat-each=10, all green.