Fix #14369: Move boolean literal evaluation to valueFlowSetConstantValue#8468
Open
francois-berder wants to merge 1 commit intodanmar:mainfrom
Open
Fix #14369: Move boolean literal evaluation to valueFlowSetConstantValue#8468francois-berder wants to merge 1 commit intodanmar:mainfrom
francois-berder wants to merge 1 commit intodanmar:mainfrom
Conversation
Previously, boolean literals were processed in a separate loop after
valueFlowSetConstantValue. This triggered nullPointer FP with code such as:
int f() {
const int* p = true ? new int() : nullptr;
return *p; // nullPointer FP
}
Because the condition token had no known value, both branches of the ternary
operator were treated as possible, leaking a spurious null value.
Signed-off-by: Francois Berder <fberder@outlook.fr>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!tok->isTemplateArg()) | ||
| value.setKnown(); | ||
| setTokenValue(tok, std::move(value), settings); | ||
| } else if ((tok->isCpp() || settings.standards.c >= Standards::C23) && (tok->isName() && !tok->varId() && Token::Match(tok, "%bool%"))) { |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, boolean literals were processed in a separate loop after valueFlowSetConstantValue. This triggered nullPointer FP with code such as:
int f() {
const int* p = true ? new int() : nullptr;
return *p; // nullPointer FP
}
Because the condition token had no known value, both branches of the ternary operator were treated as possible, leaking a spurious null value.