address issues 20 and 22 - #23
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors to the testing infrastructure, package metadata, and example data scripts for the
modpodsproject. The main focus is on expanding and standardizing support for multiple optimization methods (Bayesian, Differential Evolution, and Dual Annealing) across all test suites, updating package metadata for PyPI compatibility, and providing a reproducible data-fetching script for USGS Delaware River data.Testing and Optimization Methods:
test_bayesian.py,test_integrated.py,test_camels.py, andtests/test_modpods.py) to systematically test and compare multiple optimization methods (bayesian,differential_evolution, anddual_annealing) instead of only compass search or Bayesian optimization. Tests now report and compare R² scores across all methods. [1] [2] [3] [4] [5] [6]tests/test_modpods.pyto provide models trained with each optimizer, and added corresponding validation tests. [1] [2] [3]Package Metadata and Build System:
pyproject.tomlandmodpods.egg-infofiles to specify dependencies, Python version, project metadata, and build configuration for PyPI distribution. [1] [2] [3] [4]Data and Documentation:
testing_data/pull_usgs_delaware.pythat fetches and processes USGS Delaware River gauge height data for testing, including data normalization and plotting. The script demonstrates reproducible data fetching without committing large files to the repository.IDEA.mdto reference enhancements tracked in the project’s GitHub issues.Minor/Other:
test_camels.pyto ensure correct loading from thetests/datadirectory.modpods.py.bak(purpose not specified).These changes collectively improve the robustness, maintainability, and reproducibility of the
modpodspackage and its test suite.