Fix --force-pull on bundle summary and bundle open#5028
Open
simonfaltum wants to merge 1 commit intomainfrom
Open
Fix --force-pull on bundle summary and bundle open#5028simonfaltum wants to merge 1 commit intomainfrom
simonfaltum wants to merge 1 commit intomainfrom
Conversation
Both commands declared the flag but never passed it into ProcessOptions.AlwaysPull, so it silently no-oped and users were served stale local state. Wire forcePull into AlwaysPull in both commands to match the pattern in pipelines open and bundle debug states. Co-authored-by: Isaac
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
--force-pullonbundle summaryandbundle openis silently ignored: both commands declare the flag but never pass it through, so the local state cache is used even when the user explicitly asks for a remote pull. Users see stale URLs or IDs and have no way to bypass the cache short of deleting.databricks/by hand.The flag works as expected on
pipelines openandbundle debug states.Changes
Wire
forcePullintoProcessOptions.AlwaysPullincmd/bundle/summary.goandcmd/bundle/open.goso the flag reachesstatemgmt.PullResourcesState. This matches the pattern used in the two commands where the flag already works.No behavior change when the flag is unset.
Test plan
acceptance/bundle/state/force_pull_commands/asserts that a workspace-files state GET is issued only when--force-pullis set, for bothbundle summaryandbundle open. Runs under both engines via EnvMatrix.