Make clientId optional in DatabricksOAuthTokenSource#765
Open
renaudhartert-db wants to merge 2 commits intomainfrom
Open
Make clientId optional in DatabricksOAuthTokenSource#765renaudhartert-db wants to merge 2 commits intomainfrom
renaudhartert-db wants to merge 2 commits intomainfrom
Conversation
Users authenticating via web browser OIDC federation flows do not have a client ID in their IdP JWT token. RFC 8693 makes client_id optional for token exchange requests. The SDK was over-constraining by requiring it. Skip the client_id parameter when it is null or empty. Fixes #757
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
renaudhartert-db
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
renaudhartert-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Contributor
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
renaudhartert-db
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabricksOAuthTokenSourcerequired a non-null, non-emptyclientId, which blocked users authenticating via web browser OIDC federation flows where no client ID is available in the IdP JWT token.client_idoptional for token exchange requests. Theclient_idparameter is now only included when the value is non-null and non-empty. Fully backward compatible.Test plan
NullPointerException)IllegalArgumentException)client_idis absent from the request bodyDatabricksOAuthTokenSourceTesttests passfmt-maven-pluginFixes #757