Fix IME Enter submitting chat messages on macOS#528
Open
Y1fe1Zh0u wants to merge 1 commit intodataelement:mainfrom
Open
Fix IME Enter submitting chat messages on macOS#528Y1fe1Zh0u wants to merge 1 commit intodataelement:mainfrom
Y1fe1Zh0u wants to merge 1 commit intodataelement:mainfrom
Conversation
macOS Chinese IMEs can emit Enter keydown events while committing a candidate. The chat inputs already checked isComposing, but browser composition boundary timing can still surface IME-processed keydown events with keyCode 229, so both chat send handlers now keep those events out of the submit path. Constraint: Preserve existing Enter-to-send and Shift+Enter newline behavior Rejected: Switch sending to Cmd+Enter | broader UX change than the issue requires Confidence: high Scope-risk: narrow Directive: Keep IME guards on every keyboard shortcut that submits user-entered text Tested: npm run build Not-tested: Manual macOS Chinese IME browser reproduction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #524