chore(ci): add bundled-preset grep gate for trademarked characters - #114
Closed
sjkncs wants to merge 1 commit into
Closed
chore(ci): add bundled-preset grep gate for trademarked characters#114sjkncs wants to merge 1 commit into
sjkncs wants to merge 1 commit into
Conversation
been there — a contributor copy-pastes a persona description, it gets merged, three weeks later a takedown lands and now we all scramble to redact the release. drop a small grep gate in scripts/. it walks apps/ and packages/, skips test + build dirs, scans ts/tsx/mjs/js/cjs/json, and bails on a hit. default keyword list covers the usual animation + game studios (Vocaloid family, Kagamine, Re:Zero, Touhou, Genshin, Arknights, Blue Archive, Star Rail) — easy to extend, one regex per brand. the script does nothing by itself. not wired into prebuild or CI yet, that part is up to maintainers. the point of this PR is to have the utility in tree so the conversation about whether to run it is concrete instead of abstract. verified against this repo's source tree: zero hits, exit 0. not blocking on anything. close if you don't want the gate; the script will just sit in tree unused and cost nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey — small one to start.
a contributor copy-pastes a persona description, it gets merged, three weeks later a takedown lands and now we're all scrambling to redact a release. been there, would rather not be there again.
this adds a 150-line grep gate in
scripts/check-no-bundled-presets.mjs. walksapps/andpackages/, skips test + build dirs, fails the build on a banned keyword. default list covers the usual animation + game studios — Vocaloid family, Kagamine, Re:Zero, Touhou, Genshin, Arknights, Blue Archive, Star Rail. adding a new brand is one regex.the script does nothing on its own. not hooked into prebuild or CI in this PR — that's a deliberate choice so this lands as a small, reviewable diff. wiring it in is two more lines on top, happy to stack as a follow-up.
verified against this repo's source tree: zero hits, exit 0. tested the same gate on the sibling fork that already runs it everywhere — it caught two accidental drops before they hit main, which is what made me confident enough to send it.
not blocking on anything. close if you don't want it; the script will just sit in tree unused and cost nothing.
happy to:
scripts/ci/if you have a convention)bundled-presets)let me know.