Fixing the rectangular area operations! - #549
Merged
Merged
Conversation
…n't operate where it shouldn't.
… double-width lines
For VT420 and K95 terminal types at least. While the VT520s behaviour is probably the result of a bug, its still the way the VT520 behaves so when those terminal emulations eventually appear they'll behave as the hardware does.
…bold attribute to apply to the background rather than the foreground. I assume this is true for the VT100 and VT320 as well. Kermit 95 has never done this in the past. Now it does.
I can't see there being any risk of compatibility issues in doing this.
…or the K95 terminal type only. The "Reverse All" operation excludes these attributes (Reverse most?) just in case there is anything out there that might be relying on the specific attributes Reverse All reverses.
# Conflicts: # doc/changes.md
davidrg
marked this pull request as ready for review
July 28, 2026 09:52
… things. Also reduced wait times for some tests now that K95s telnet client has somewhat higher throughput.
Also, move parameter validation for the non-DECOM case to outside the loop as it only needs to happen once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing tests from the test suite linked in #547:
A lot of the issues so far are resolved by reducing the copy&paste by moving all of the rectangular area validation, etc, into a function shared by all the rectangular area operations, and then fixing the bug once rather than six times