Overline Attribtue - #555
Merged
Merged
Conversation
davidrg
force-pushed
the
overline-attribute
branch
from
July 31, 2026 05:01
68c8652 to
1f268e1
Compare
…d member variable.
I was strongly tempted to just treat overline as a synonym for underline in console versions of K95, and in K95G have no way of disabling it. But that would be inconsistent with the way all other attributes are handled. So while probably no one will ever turn overline off, assign it a colour, and then use something that makes use of overline, it now behaves as all the other attributes do.
davidrg
marked this pull request as ready for review
July 31, 2026 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been on the list of potential new attributes to support for a while, and vtfontmaker uses it so time to implement it!