Fix handling of the Dim attribute. - #557
Merged
Merged
Conversation
It should be applied in much the same way as bold attribute - if reverse video is active, then the background is dimmed rather than the foreground. Also not handled previously was changing colours while the dim attribute was set - this would cause the dim attribute to get unset. While at it, I've refactored the code that handles preparing the _K_WORK_STORE into a static method to reduce the copy&paste between the main rendering code and the render-to-image function.
davidrg
marked this pull request as ready for review
August 11, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be applied in much the same way as bold attribute - if reverse video is active, then the background is dimmed rather than the foreground. Also not handled previously was changing colours while the dim attribute was set - this would cause the dim attribute to get unset. Both of these issues should now be resolved.
While at it, I've refactored the code that handles preparing the _K_WORK_STORE into a static method to reduce the copy&paste between the main rendering code and the render-to-image function.