Fix bug with packet size negotiation - #558
Merged
Merged
Conversation
This re-implements OpenKermit/ckermit@0eef9a1 on this tree. This was detected after OpenKermit's ckermit test suite added eksw compatibility tests. A stall was observed after sending several packets to E-Kermit (eksw). C-Kermit 9.0.302 tested working with it. The bug was tracked down to a change in C-Kermit 9.0 edit 305(alpha05) of 2021-11-16. In bgetpkt(), it changed: +#ifdef COMMENT + /* No - bufmax is a parameter */ bufmax = maxdata(); /* Get maximum data length */ +#endif While the comment that bufmax is a parameter is correct, the change to set it to maxdata() was incorrect, since maxdata() accounts for overhead and bufmax does not. This resulted in packets a few bytes larger than the receiver had signaled acceptance of. C-Kermit supports such very large packets anyhow that this was never detected when talking to other C-Kermits. With this change, proper communication with ekermit (eksw) was restored.
Contributor
Author
|
BTW I am happy to do whatever I can to help with integration with OpenKermit and such. |
Owner
|
This looks like the fix for the bug I logged over here: KermitProject/ckermit#19 - seems you've confirmed my suspicion that packet size negotiation was broken by this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-implements
OpenKermit/ckermit@0eef9a1 on this tree.
This was detected after OpenKermit's ckermit test suite added eksw compatibility tests. A stall was observed after sending several packets to E-Kermit (eksw). C-Kermit 9.0.302 tested working with it.
The bug was tracked down to a change in C-Kermit 9.0 edit 305(alpha05) of 2021-11-16. In bgetpkt(), it changed:
While the comment that bufmax is a parameter is correct, the change to set it to maxdata() was incorrect, since maxdata() accounts for overhead and bufmax does not. This resulted in packets a few bytes larger than the receiver had signaled acceptance of.
C-Kermit supports such very large packets anyhow that this was never detected when talking to other C-Kermits.
With this change, proper communication with ekermit (eksw) was restored.