Bring test coverage to 100% - #107
Merged
Merged
Conversation
dblock
force-pushed
the
dblock/add-coveralls
branch
from
August 24, 2026 21:16
fa59e58 to
b1ece3e
Compare
Danger ReportNo issues found. |
dblock
force-pushed
the
dblock/add-coveralls
branch
2 times, most recently
from
August 25, 2026 02:10
3237566 to
3b48d70
Compare
- Adds tests for previously untested code: Client.configure/.config, segments explore/star bounds checks, Pagination, Ratelimit, Response, RaiseResponseError, Webhooks::Models::Challenge, and mixins (AverageSpeed, SportType, StartDateLocal) using real model instances. - Fixes explore_segments and star_segment raising UncaughtThrowError instead of ArgumentError for missing required arguments. - Fixes start_date_local to always derive the timezone offset from the difference between start_date and start_date_local, since Strava's timezone property does not account for daylight saving time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/add-coveralls
branch
from
August 25, 2026 02:11
3b48d70 to
3976324
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Now that #106 added coveralls.io reporting, this brings line coverage to 100%.
Client.configure/.config,explore_segments/star_segmentbounds checks,Pagination,Ratelimit,Response,RaiseResponseError,Webhooks::Models::Challenge, and mixins (AverageSpeed,SportType,StartDateLocal) using real model instances (no dummy mixin-only classes).explore_segmentsandstar_segmentraisingUncaughtThrowErrorinstead ofArgumentErrorfor missing required arguments (throwwas used whereraisewas intended).start_date_localto always derive the timezone offset from the difference betweenstart_dateandstart_date_local, since Strava'stimezoneproperty only reflects the zone's standard GMT offset and does not account for daylight saving time.Closes discovery from #54 coverage follow-up work.