Skip to content

Fix #267: display file sizes in GiB/MiB/KiB instead of GB/MB/KB #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
palakbhati wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #267: display file sizes in GiB/MiB/KiB instead of GB/MB/KB #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bf8bd1
Fix #267: display file sizes in GiB/MiB/KiB instead of GB/MB/KB
palakbhati Jul 10, 2026
1c776d6
Address review: delegate formatUploadSize to DatabusUtils.formatFileSize
palakbhati Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
623 changes: 322 additions & 301 deletions public/dist/main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion public/js/angular-application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ databusApplication.directive('activityChart', function () {
.attr("dy", "1em")
.attr("font-size", "1.1em")
.attr("text-anchor", "end")
.text("Uploaded Data (GByte)");
.text("Uploaded Data (GiByte)");

var path = g.append("path")
.datum(scope.data)
Expand Down
5 changes: 1 addition & 4 deletions public/js/components/collection-data-table/collection-data-table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,7 @@ function CollectionDataTableController($http, $scope, $location, $sce) {
}

ctrl.formatUploadSize = function(size) {
if(size < 1024) return size + " B";
else if (size < 1048576) return Math.round(size / 1024) + " KB";
else if (size < 1073741824) return (Math.round(10 * size / 1048576) / 10) + " MB";
else return (Math.round(100 * size / 1073741824) / 100) + " GB";
return DatabusUtils.formatFileSize(size);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

Expand Down
8 changes: 4 additions & 4 deletions public/js/utils/databus-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,13 +111,13 @@ class DatabusUtils {

static formatFileSize(size) {
if (size == undefined) {
return '0 KB'
return '0 KiB'
}

if (size < 1024) return size + " B";
else if (size < 1048576) return Math.round(size / 1024) + " KB";
else if (size < 1073741824) return (Math.round(10 * size / 1048576) / 10) + " MB";
else return (Math.round(100 * size / 1073741824) / 100) + " GB";
else if (size < 1048576) return Math.round(size / 1024) + " KiB";
else if (size < 1073741824) return (Math.round(10 * size / 1048576) / 10) + " MiB";
else return (Math.round(100 * size / 1073741824) / 100) + " GiB";
};

static checkField(value, regex, min, max) {
Expand Down
2 changes: 1 addition & 1 deletion server/app/common/queries/query-modules/pages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ function createActivityChartData(bindings) {
// Create datestring for entry and map lookup (YYYY-MM)
let dateString = date.toISOString().substring(0, 7);

// Create the entry with datestring and scaled value (GB)
// Create the entry with datestring and scaled value (GiB)
result.push({
date: dateString,
value: totalSize / (1024 * 1024 * 1024)
Expand Down