feat(fm): DTMF keypad for FM mode (DM) - #174
Merged
Merged
Conversation
FR-FM-02. A DTMF button on the FM panel opens a 4x4 keypad (0-9, A-D, *, #), each key sending one DM tone. This is the part of the gap-analysis item worth building: sending DTMF for repeater and link control is impossible over a remote link any other way. Scoped down deliberately. The 6 stored DTMF sequences are config work, deferred to a follow-up. The 1750 Hz tone burst has no documented CAT command in D12 (searched), so it is un-buildable rather than un-built - guessing a command is the RO/RA wire-format trap. send_dtmf refuses a non-DTMF character rather than emitting a malformed DM. Verified: the encoder over every keypad digit by test; the popup on screen by forcing it open in --demo (the standard telephone grid renders). Several xdotool clicks missed the FM-row button by ~40 px, so rather than keep guessing coordinates I confirmed the overlay via its open flag - the wiring mirrors the working memories and about overlays. 324 tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KiAgfnGv746wwVBSfFkoRY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FR-FM-02. A DTMF button on the FM panel opens a 4×4 keypad (0–9,A–D,*,#), each key sending oneDMtone.This is the part of the gap-analysis item worth building: sending DTMF for repeater and link control is impossible over a remote link any other way.
Scoped down deliberately
RO/RAwire-format trap this project has hit.send_dtmfrefuses a non-DTMF character rather than emitting a malformedDM.Verification
--demo: the standard telephone grid (1 2 3 A / 4 5 6 B / 7 8 9 C / * 0 # D).A method note: several xdotool clicks missed the FM-row button by ~40 px, so rather than keep guessing coordinates I confirmed the overlay via its open flag — the wiring mirrors the working memories/about overlays.
Branches from
main(v0.7.0).🤖 Generated with Claude Code
https://claude.ai/code/session_01KiAgfnGv746wwVBSfFkoRY